Skip to content

Deprecate unused rcParams["animation.html_args"]. #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Deprecate unused rcParams["animation.html_args"]. #15318

merged 1 commit into from
Mar 24, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 21, 2019

I guess it was intended as a parallel for e.g. animation.ffmpeg_args
-- a list of command-line arguments additionally passed to ffmpeg -- but
no external program is used by the html animation writer.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecate unused rcParams["animation.html_args"].
07d8a51 
I guess it was intended as a parallel for e.g. `animation.ffmpeg_args`
-- a list of command-line arguments additionally passed to ffmpeg -- but
no external program is used by the html animation writer.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2020

rebased

@timhoffm timhoffm added this to the v3.3.0 milestone Mar 24, 2020
@timhoffm timhoffm merged commit 796e68e into matplotlib:master Mar 24, 2020
@anntzer anntzer deleted the htmlextraargs branch March 24, 2020 18:17
@QuLogic QuLogic mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation topic: rcparams
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm