Add 'step' and 'barstacked' to histogram_histtypes demo #15357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the step histogram type to the histtype demo
|
I had a look at the CircleCI logs and there are a lot of errors which relate to files which are not changed in this pull request. |
| ax0.set_title('stepfilled') | ||
| fig, axs = plt.subplots(nrows=2, ncols=2) | ||
|
|
||
| axs[0, 0].hist(x, 20, density=True, histtype='stepfilled', facecolor='g', alpha=0.75) |
There was a problem hiding this comment.
This line is too long, hence the test error
./examples/statistics/histogram_histtypes.py:30:80: E501 line too long (85 > 79 characters)
There was a problem hiding this comment.
Oops, I have fixed the line. The CircleCI build was failing once I did this due to a missing import fixed in 4677fd9
timhoffm
reviewed
Oct 3, 2019
timhoffm
approved these changes
Oct 4, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 4, 2019
…m_histtypes demo
timhoffm
pushed a commit
that referenced
this pull request
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add example plots for the
stepandbarstackedhistogram types to thehistogram_histtypesdemo. This partially addresses the discussion in #7121 by adding examples of all four available histtypes.PR Checklist