Skip to content

Simplify implementation of vectorized date operations. #15390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 7, 2019

  1. We don't need to handle separately the scalar case -- tolist()
    returns a scalar when called on a 0d-array, as returned by
    np.vectorize() when called on a scalar.
  2. We don't need to handle separately the empty case, as long as the
    output type ("O") is passed to np.vectorize.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

1) We don't need to handle separately the scalar case -- tolist()
   returns a scalar when called on a 0d-array, as returned by
   np.vectorize() when called on a scalar.
2) We don't need to handle separately the empty case, as long as the
   output type ("O") is passed to np.vectorize.
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@timhoffm timhoffm added this to the v3.3.0 milestone Oct 16, 2019
@timhoffm timhoffm merged commit befecbe into matplotlib:master Oct 16, 2019
@anntzer anntzer deleted the vdates branch October 16, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants