catch OSError instead of FileNotFoundError in _get_executable_info to resolve #15399 #15413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While finding available movie writers, if the executable is presented but cannot be run, the import process will fail upon calling '_get_executable_info' since it only handled CalledProcessError and FileNotFoundError. In this commit, we catch OSError instead of FileNotFoundError in '__init__.py' and log the error message in 'animation.py' to improve the import robustness.
|
I think we should still catch FileNotFoundError as well. |
|
Should we? I thought OSError covers FileNotFoundError already. |
|
Oh yes, sorry; that's the built-in |
ImportanceOfBeingErnest
approved these changes
Oct 13, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 13, 2019
…ror in _get_executable_info to resolve matplotlib#15399
|
Thanks @immaxchen ! Congratulations on your first merged Matplotlib pull request 🎉 Hopefully we will hear from you again! |
|
Thanks to Ernest's guidance on the solution, I'll try to keep it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
While finding available movie writers, if the executable is presented but
cannot be run, the import process will fail upon calling '_get_executable_info'
since it only handled CalledProcessError and FileNotFoundError.
In this commit, we catch OSError instead of FileNotFoundError in '__init__.py'
and log the error message in 'animation.py' to improve the import robustness.
PR Checklist