Skip to content

Improve example for tick formatters #15452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2019
Merged

Improve example for tick formatters #15452

merged 1 commit into from
Oct 29, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Oct 20, 2019 •
edited
Loading

PR Summary

  • Cleanup to make the code more compact and readable.
  • Nicer formatting of the titles (color and monospaced font).
  • Meaningful summary at the top.
  • Changed the strings for FormatStrFormatter and StrMethodFormatter.

For comparison:

@timhoffm timhoffm modified the milestones: v3.1-doc, v3.1.2 Oct 20, 2019
@jklymak
Copy link
Member

jklymak commented Oct 20, 2019

Ummm, is the "Fixed Formatter" what we want the minor ticks to be labeled as? Yes, it was wrong before but maybe we can fix it while we are here?

@timhoffm timhoffm force-pushed the doc-tick-formatters branch from cd8464b to b7354a6 Compare October 21, 2019 18:39
@tacaswell tacaswell modified the milestones: v3.1.2, v3.2.0 Oct 22, 2019
@QuLogic
Copy link
Member

QuLogic commented Oct 24, 2019

The minor ticks for FixedFormatter seem very wrong in both versions. I wonder when this broke. Can this be fixed?

@timhoffm
Copy link
Member Author

timhoffm commented Oct 24, 2019 •
edited
Loading

To be honest, I don't understand neither the major nor the minor ticks in the FixedFormatter case. But that's something to be investigated separtely (#15501). This PR is about cleanup and layout of the example. It does not touch the logic of FixedFormatter.

@timhoffm
Copy link
Member Author

Will change to use a FixedLocator for the FixedFormatter example.

@timhoffm timhoffm force-pushed the doc-tick-formatters branch from b7354a6 to c930d8a Compare October 24, 2019 21:01
@timhoffm
Copy link
Member Author

https://25911-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/ticks_and_spines/tick-formatters.html#sphx-glr-gallery-ticks-and-spines-tick-formatters-py

@jklymak jklymak self-requested a review October 29, 2019 20:22
@timhoffm timhoffm force-pushed the doc-tick-formatters branch from c930d8a to b0a4959 Compare October 29, 2019 20:23
@jklymak jklymak merged commit 90fc3dc into matplotlib:master Oct 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 29, 2019
@jklymak
Backport PR matplotlib#15452: Improve example for tick formatters
612b620
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 29, 2019
Merged
@timhoffm timhoffm deleted the doc-tick-formatters branch October 29, 2019 22:51
jklymak added a commit that referenced this pull request Oct 30, 2019
@jklymak
Merge pull request #15572 from meeseeksmachine/auto-backport-of-pr-15…
3c578f6 
…452-on-v3.2.x

Backport PR #15452 on branch v3.2.x (Improve example for tick formatters)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest left review comments

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak Awaiting requested review from jklymak

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@timhoffm @jklymak @QuLogic @dopplershift @ImportanceOfBeingErnest @tacaswell