Fix incorrect value check in axes_grid. #15460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this didn't fail, does it need a test? |
808c011 to
cd8d4f9
Compare
|
sure, let's test that... |
timhoffm
approved these changes
Oct 21, 2019
jklymak
approved these changes
Oct 21, 2019
|
It'd be nice to check that the exception is raised, but this is still an improvement... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 21, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 21, 2019
|
@meeseeksdev backport to v2.2.5 |
|
Something went wrong ... Please have a look at my logs. It seem that the branch you are trying to backport to does not exists. |
|
@meeseeksdev backport to v2.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 21, 2019
tacaswell
added a commit
that referenced
this pull request
Oct 22, 2019
…460-on-v2.2.x Backport PR #15460 on branch v2.2.x (Fix incorrect value check in axes_grid.)
tacaswell
added a commit
that referenced
this pull request
Oct 22, 2019
…460-on-v3.1.x Backport PR #15460 on branch v3.1.x (Fix incorrect value check in axes_grid.)
tacaswell
added a commit
that referenced
this pull request
Oct 22, 2019
…460-on-v3.2.x Backport PR #15460 on branch v3.2.x (Fix incorrect value check in axes_grid.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The mistake came in at https://github.com/matplotlib/matplotlib/pull/10091/files#diff-3ddd29752271f4c2798bdf132a2b4673L491, sorry about that.
This patch is necessary to make the example at #9778 runnable.
On the other hand I think the fact that this was in in mpl2.2 and 3.0 and 3.1 and no one has complained about it so far says something about the extent to which axes_grid is (un)used...
I guess it would be nice to backport this to 2.2.5 and 3.1.x as well, but again, no one has complained :)
PR Checklist