Use FixedFormatter only with FixedLocator #15507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable, but fails 15 tests! |
63bf548 to
27df784
Compare
4f9a9fe to
332cb4a
Compare
jklymak
reviewed
Oct 31, 2019
332cb4a to
88d178d
Compare
|
|
88d178d to
c779568
Compare
jklymak
reviewed
Nov 1, 2019
578236a to
29b63c7
Compare
jklymak
approved these changes
Nov 1, 2019
anntzer
reviewed
Dec 2, 2019
29b63c7 to
d538802
Compare
anntzer
reviewed
Dec 2, 2019
actually a real (minor) thing to fix on the warning too
8481e72 to
a473ba1
Compare
a473ba1 to
4b5284f
Compare
|
Ping @anntzer warning fixed. |
anntzer
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR prevents users from stumbling into #7122, #8779, #15501.
It does not technically fix them,
FixedFormatterhas a one-off bug with locators other thanFixedLocator. But setting fixed labels at unknown positions is anyway not a good idea. So even if the one-off bug was fixedFixedFormattershould only used withFixedLocator.FixedFormattershould not be used without aFixedLocator(along the hierarchy of tick label setter methods).set_major/minor_formatter()if aFixedFormatteris set without aFixedLocator. This may be debatable.One could set the formatter first and the locator afterwards, which would technically yield the correct result. However, I feel that setting the position first and the labels second is the natural way, and is actually done throughout the library.
No alternative: Since Formatters don't know about Locators
FixedFormatteritself cannot check at runtime and we have to resort to this somewhat clumsy approach.And I strongly want some feedback on this potential problem from running code, because nobody reads the docs 😄.