Skip to content

Conversation

dstansby
Copy link
Member

I have taken a pretty awful docstring and made it slightly less awful by putting it in numpydoc format... not perfect but slightly better.

@dstansby dstansby added this to the v3.2.0 milestone Oct 25, 2019
@@ -218,6 +218,19 @@ def _rgb_to_rgba(A):


class _ImageBase(martist.Artist, cm.ScalarMappable):
"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to move this up to avoid it appearing under the AxesImage main docstring (this doesn't affect the docs though since _ImageBase isn't in there).

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could copy a lot of the parameter descriptions from imshow.

Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstansby ! This looks good to me.

When True, use a full resampling method. When False, only resample when
the output image is larger than the input image.
**kwargs
Additional kwargs are matplotlib.artist properties.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use backticks around matplotlib.artist, sphinx should do it's magic and automatically link to the reference page of the artist. It's pretty cool :)

@NelleV NelleV merged commit 055192c into matplotlib:master Oct 28, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 28, 2019
@dstansby dstansby deleted the axesim-numpydoc branch October 28, 2019 14:26
timhoffm added a commit that referenced this pull request Oct 28, 2019
…523-on-v3.2.x

Backport PR #15523 on branch v3.2.x (numpydoc AxesImage)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants