-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use svg instead of png for website logo #15533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should look into trying to shirk the svg before we make this change. The png in 20k, the svg is 128k. The whole site is currently ~300k and we are worrying about 160k per font in #15516 . |
I've compressed the svg from 128k to 11k using https://vecta.io/nano (precision level 2). That includes a slightly lossy compression (nodes are slightly moved), but you won't notice unless really flipping back and forth on larger magnifications. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
I spoke with @dorafc about this. Her only concern was if all browsers would support this. According to https://caniuse.com/#feat=svg everything but dangerously out of date IE does. There is a handful (~130 / 276,000 in the last week) of users who would be hit by this but it is probably but it is not enough to worry about. |
…533-on-v3.2.x Backport PR #15533 on branch v3.2.x (Use svg instead of png for website logo)
I'm working on backporting this to the 3.1 series. |
Use svg instead of png for website logo Conflicts: doc/_templates/layout.html - git is having trouble patching html
Backported directly to v3.1.1-doc as 7830e26 and will get onto v3.1.x by merging v3.1.1-doc into v3.1.x before tagging v3.2.0. |
PR Summary
This reverts an accidental flip svg -> png introduced in #10065. Sorry for the error!