Skip to content

Use svg instead of png for website logo #15533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Conversation

timhoffm
Copy link
Member

PR Summary

This reverts an accidental flip svg -> png introduced in #10065. Sorry for the error!

@tacaswell
Copy link
Member

tacaswell commented Oct 26, 2019

We should look into trying to shirk the svg before we make this change. The png in 20k, the svg is 128k. The whole site is currently ~300k and we are worrying about 160k per font in #15516 .

@tacaswell tacaswell modified the milestones: v3.2.0, v3.1-doc Oct 26, 2019
@timhoffm
Copy link
Member Author

I've compressed the svg from 128k to 11k using https://vecta.io/nano (precision level 2). That includes a slightly lossy compression (nodes are slightly moved), but you won't notice unless really flipping back and forth on larger magnifications.

@jklymak jklymak merged commit 2184402 into matplotlib:master Oct 27, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 27, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2184402cf7fcccb25c24566c190655319f22837a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15533: Use svg instead of png for website logo'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-15533-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #15533 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 27, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.1-doc
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2184402cf7fcccb25c24566c190655319f22837a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15533: Use svg instead of png for website logo'
  1. Push to a named branch :
git push YOURFORK v3.1.1-doc:auto-backport-of-pr-15533-on-v3.1.1-doc
  1. Create a PR against branch v3.1.1-doc, I would have named this PR:

"Backport PR #15533 on branch v3.1.1-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@tacaswell
Copy link
Member

I spoke with @dorafc about this. Her only concern was if all browsers would support this. According to https://caniuse.com/#feat=svg everything but dangerously out of date IE does. There is a handful (~130 / 276,000 in the last week) of users who would be hit by this but it is probably but it is not enough to worry about.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 27, 2019
tacaswell added a commit that referenced this pull request Oct 27, 2019
…533-on-v3.2.x

Backport PR #15533 on branch v3.2.x (Use svg instead of png for website logo)
@tacaswell
Copy link
Member

I'm working on backporting this to the 3.1 series.

@timhoffm timhoffm deleted the svg-logo branch October 28, 2019 00:57
tacaswell pushed a commit that referenced this pull request Oct 28, 2019
Use svg instead of png for website logo

Conflicts:
	doc/_templates/layout.html
          - git is having trouble patching html
@tacaswell
Copy link
Member

Backported directly to v3.1.1-doc as 7830e26 and will get onto v3.1.x by merging v3.1.1-doc into v3.1.x before tagging v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants