Simplify OldAutoLocator and AutoDateLocator. #15606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both classes the
refresh
method only sets the_locator
attribute,which is only later called in
__call__
-- but__call__
also callsrefresh
first. So we can instead inline the contents ofrefresh
into
__call__
, get rid of therefresh
implementation (inheritingthe do-nothing implementation of the base class) and get rid of the
_locator
attribute, as this has no publically observable effect.Likewise,
AutoDateLocator.set_axis
can go.PR Summary
PR Checklist