Skip to content

Cleanup mpl_toolkits locators. #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2020
Merged

Cleanup mpl_toolkits locators. #15622

merged 1 commit into from
Mar 14, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 7, 2019

mpl_toolkits locators have a separate API from "normal" Locators. Work
towards unifying them by deprecating the unused set_factor method.

Also remove a branch for the never-unset _ignore_factor attribute of
FormatterPrettyPrint.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby
Copy link
Member

dstansby commented Nov 9, 2019

Just tried fixing the merge conflict with the web UI for the first time

@anntzer anntzer force-pushed the mpl_toolkits-locators branch from b9354da to df7e944 Compare March 12, 2020 09:57
@anntzer
Copy link
Contributor Author

anntzer commented Mar 12, 2020

rebased

@timhoffm
Copy link
Member

Anybody can merge after rebase.

@anntzer
Cleanup mpl_toolkits locators.
2397e94 
mpl_toolkits locators have a separate API from "normal" Locators.  Work
towards unifying them by deprecating the unused set_factor method.

Also remove a branch for the never-unset _ignore_factor attribute of
FormatterPrettyPrint.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 14, 2020

rebased

@anntzer anntzer force-pushed the mpl_toolkits-locators branch from df7e944 to 2397e94 Compare March 14, 2020 19:03
@timhoffm timhoffm merged commit 9f67e4b into matplotlib:master Mar 14, 2020
@timhoffm timhoffm added this to the v3.3.0 milestone Mar 14, 2020
@anntzer anntzer deleted the mpl_toolkits-locators branch March 14, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dstansby @timhoffm @QuLogic