Skip to content

Make it easier to test various animation writers in examples. #15627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

Make it easier to test various animation writers in examples. #15627

merged 1 commit into from
Nov 7, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 7, 2019

The change here allows one to change animation writer by editing a
single place rather than two (both the import and the actual use).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Make it easier to test various animation writers in examples.
9a092c7 
The change here allows one to change animation writer by editing a
single place rather than two (both the import and the actual use).
@ImportanceOfBeingErnest ImportanceOfBeingErnest modified the milestones: v3.3.0, v3.2.0 Nov 7, 2019
ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit 3d3460e into matplotlib:master Nov 7, 2019
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 7, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 7, 2019
@anntzer
Backport PR matplotlib#15627: Make it easier to test various animatio…
7bf7beb 
…n writers in examples.
@anntzer anntzer deleted the animexamples branch November 7, 2019 20:20
ImportanceOfBeingErnest pushed a commit that referenced this pull request Nov 7, 2019
@meeseeksmachine @ImportanceOfBeingErnest
Backport PR #15627: Make it easier to test various animation writers …
43665e0 
…in examples. (#15632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @ImportanceOfBeingErnest