Skip to content

Rewrite cursor example to include speedup possibilities #15644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

Rewrite cursor example to include speedup possibilities #15644

merged 1 commit into from
Jan 13, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Nov 9, 2019 •
edited
Loading

PR Summary

  • Cleaned up the two existing implementations a bit.
  • Hide the cross hair when the cursor leaves the Axes (IMHO more reasonable than letting it stay visible at some random position near the border).
  • Sped up the SnappingCursor by only redrawing if the indicated data point changes.
  • Added an implementation using blitting.

QuLogic
QuLogic reviewed Nov 10, 2019
View reviewed changes
QuLogic
QuLogic reviewed Nov 10, 2019
View reviewed changes
@timhoffm timhoffm force-pushed the cursor-demo-update branch 2 times, most recently from 7cb1770 to 013d478 Compare November 10, 2019 11:41
anntzer
anntzer reviewed Jan 11, 2020
View reviewed changes
examples/misc/cursor_demo_sgskip.py Outdated
ax.set_title('Simple cursor')
ax.plot(x, y, 'o')
cursor = Cursor(ax)
fig.canvas.mpl_connect('on_mouse_move', cursor.mouse_move)
Copy link
Contributor

@anntzer anntzer Jan 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursor.on_mouse_move (below a few more times as well)

I think this could be unsgskipped? Sure the image would be static, but at least this would catch the AttributeError...

Also the event name is motion_notify_event...

anntzer
anntzer reviewed Jan 11, 2020
View reviewed changes
examples/misc/cursor_demo_sgskip.py Outdated

For simplicity, this assumes that *x* values of he data is sorted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the data" (typo)

@timhoffm timhoffm mentioned this pull request Jan 11, 2020
Closed
@anntzer anntzer mentioned this pull request Jan 13, 2020
Merged
6 tasks
@anntzer anntzer merged commit 0da4c78 into matplotlib:master Jan 13, 2020
@timhoffm timhoffm added this to the v3.3.0 milestone Jan 13, 2020
@timhoffm timhoffm deleted the cursor-demo-update branch January 13, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @anntzer