Bump minimal numpy version to 1.12. #15645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Numpy 1.12 was released in January 2017 (https://github.com/numpy/numpy/tags?after=v1.12.1), which will be more than 3y ago when mpl3.3 will be released, so it's fine to depend on it per the dependency policy. Numpy 1.12 added pathlib support for numpy.load, a minor convenience for improving cbook.get_sample_data.
|
You might as well bump all the way up to 1.14.3 And if you are brave, simply jump ship and go to numpy 1.15 FWIW, building with numpy 1.13.3 creates incompatibilities with numpy 1.15 |
|
technically we haven't adopted NEP29 here yet (I'm fine with doing so, but that's not so much the point of this PR). |
tacaswell
approved these changes
Nov 10, 2019
|
Could have sworn I opened a PR to adopt NEP29 for 3.3.... |
dstansby
approved these changes
Nov 11, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 1.12 was released in January 2017
(https://github.com/numpy/numpy/tags?after=v1.12.1), which will be more
than 3y ago when mpl3.3 will be released, so it's fine to depend on it
per the dependency policy.
Numpy 1.12 added pathlib support for numpy.load
(numpy/numpy#6660),
a minor convenience for improving cbook.get_sample_data (#15641).
PR Summary
PR Checklist