np.concatenate cleanups. #15679
Merged
np.concatenate cleanups. #15679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace np.concatenate by iterable unpacking when the arrays are short (so performance doesn't matter) and legibility is improved, or by np.roll(), or by np.append.
QuLogic
reviewed
Nov 13, 2019
|
|
||
| n = hour_limits.searchsorted(dv) | ||
| n = np.searchsorted(hour_limits, dv) | ||
| step = hour_steps[n] |
There was a problem hiding this comment.
How does this work? n is an array still, but hour_steps is a list now, and I can't index a list with an array.
There was a problem hiding this comment.
dv is a scalar (this is called by select_step, where it is immediately preceded by if dv > 1 / threshold_factor -- semantically, it is the distance between the axes bounds) so n is a scalar as well and the indexing is fine.
I guess technically it is an API break in that select_step_degree could have been called directly by someone passing dv as an array, but I don't think this is a real issue (and is clearly not how select_step_degree was designed to do).
There was a problem hiding this comment.
s/preceded/succeeded/, but I see what you mean.
timhoffm
approved these changes
Nov 13, 2019
QuLogic
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace np.concatenate by iterable unpacking when the arrays are short
(so performance doesn't matter) and legibility is improved, or by
np.roll(), or by np.append.
PR Summary
PR Checklist