Avoid a RuntimeError at animation shutdown with PySide2. #15685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Nov 13, 2019
|
fwiw I can also repro the issue now, and its resolution by this PR, using PyQt5 -- run animation/strip_chart.py, wait for the strip chart to go at least once through the axes, and quit. |
|
@anntzer Do I understand your correctly: The bug should happen when running That quits cleanly here. (Not tested with PySide2 as I've not installed that.) |
|
Yes, it fails locally with me at exit with qt5agg/master. Did you wait for the strip chart to go at least once through the whole axes? |
|
Yes I did. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 14, 2020
…own with PySide2.
QuLogic
added a commit
that referenced
this pull request
Mar 14, 2020
…685-on-v3.2.x Backport PR #15685 on branch v3.2.x (Avoid a RuntimeError at animation shutdown with PySide2.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the "Internal C++ object already deleted" part of #15678 (comment) (@dopplershift, perhaps this also fixes the rest if you're lucky?).
See mottosso/Qt.py#316 for how to translate the isdeleted API with PySide. See #9993 (comment) re the "double import" of sip with PyQt4.
PR Checklist