Skip to content

Conversation

manan2501
Copy link
Contributor

PR Summary

I have added boxplot rcparams to dark_background.mplstyle as suggested by @tacaswell to make boxes visible in dark_background style which will solve issue #15675 .

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

I have added boxplot rcparams to dark_background.mplstyle as suggested by @tacaswell to make boxes visible in dark_background style which will solve issue #15675 .
Added boxplot rcparams to dark_background.mplstyle
@manan2501 manan2501 closed this Nov 17, 2019
@QuLogic
Copy link
Member

QuLogic commented Nov 19, 2019

Why did you close this?

@manan2501
Copy link
Contributor Author

Why did you close this?

I had installed matplotlib according to this => https://matplotlib.org/3.1.1/users/installing.html#installing-from-source
But, after making changes to mplstyle file, they were not observed while testing (Even changing the value of colors were not observed). So, I was not sure that this would work. That is why I closed this PR.
(If possible guid me to some doc which can help me in the testing part. Because I will need it for sure in the future.)

@QuLogic
Copy link
Member

QuLogic commented Nov 19, 2019

See the developer's guide. If you have trouble, try asking on Discourse or Gitter, which are better places for this than a GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants