Skip to content

Fix home/forward/backward buttons for 3d plots. #15734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

Fix home/forward/backward buttons for 3d plots. #15734

merged 1 commit into from
Dec 30, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 20, 2019

No tests because good luck with that, but can be checked manually.

Closes #11178.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that it works.

@dstansby dstansby added this to the v3.3.0 milestone Dec 29, 2019
dstansby
dstansby approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a changelog for this?

@anntzer
Copy link
Contributor Author

anntzer commented Dec 29, 2019

sure, done

@anntzer
Fix home/forward/backward buttons for 3d plots.
d473d45 
No tests because good luck with that, but can be checked manually.
@timhoffm timhoffm merged commit c041352 into matplotlib:master Dec 30, 2019
@anntzer anntzer deleted the 3dhome branch December 30, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

home/back/forward buttons do nothing in 3d mode
3 participants
@anntzer @timhoffm @dstansby