Move Text init to end of Annotation init. #15747
Conversation
|
Not sure if this is a good design pattern overall. We require Would that pattern be suitable for |
7cf5845 to
6a4e8fc
Compare
|
That looks better to me, adapted accordingly. |
There was a problem hiding this comment.
I suppose this is ok.
A bit hesitant because this changes the code path for Text properties. They are not initialized via Text.__init__ anymore but via a deffered update(). In a way, this assumes something about the inner workings of Text. OTOH, t = Text(); t.update(kwargs) is public and the effect is (and I assume is guaranteed) to be equivalent to Text(**kwargs). The former might just be (I think currently is not) a little more inefficient.
IMHO the really clean approach would be to pass Text properties to Text.__init__() and update properties specific to Annotation. But maybe we don't hae to overdo it here.
... in case some kwargs (each of which is handled by calling a set_foo) need to refer to arrow_patch.
6a4e8fc to
2f6eaf5
Compare
|
Actually, instead of splitting Text init in two, I can move the whole init after setting up the arrow_patch, which should alleviate your concerns. |
PR Summary
... in case some kwargs (each of which is handled by calling a set_foo)
need to refer to arrow_patch). Closes #15745.
I nearly told the OP of #15745 that he needed to create an annotation without setting axes and figure because add_text (like add_line) would take care of it for him... but _add_text is private, for some reason (probably should be public, like add_line and friends?)
Small neighboring cleanup in a separate commit.
PR Checklist