Skip to content

Cleanup Colormap.__call__. #15787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 28, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- Remove ref. to class doctsring: parameters are new documented in
  method docstring.
- Don't fill the "bad" values in the array to avoid a warning; correctly
  set the warnings filter instead (hopefully should be faster, for large
  inputs).
- Don't compute `np.isnan(X)` twice -- once is enough.  Don't bother
  "optimizing" by checking whether `np.any(np.isnan(X))` -- that'll need
  iterating over the whole array as well.
- Remove reference to very old (and now fixed) putmask endianness bug.
- Indexing is just as fast as ndarray.take nowadays, and clearer.
@story645 story645 merged commit fdfcbeb into matplotlib:master Nov 29, 2019
@anntzer anntzer deleted the colormap-call branch November 29, 2019 19:44
@QuLogic QuLogic added this to the v3.3.0 milestone Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants