Skip to content

Remove incorrect statement re: colorbars in image tutorial. #15795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2019
Merged

Remove incorrect statement re: colorbars in image tutorial. #15795

merged 1 commit into from
Dec 1, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 30, 2019

Colorbars actually do auto-update their cmap to match the image's cmap.
I don't think it's worth mentioning that in an intro tutorial, but at
least remove the incorrect statement.

Noted while looking at #15793.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove incorrect statement re: colorbars in image tutorial.
283a719 
Colorbars actually do auto-update their cmap to match the image's cmap.
I don't think it's worth mentioning that in an intro tutorial, but at
least remove the incorrect statement.
@timhoffm timhoffm added this to the v3.2.1 milestone Dec 1, 2019
@timhoffm timhoffm merged commit b015209 into matplotlib:master Dec 1, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 1, 2019
@timhoffm
Backport PR matplotlib#15795: Remove incorrect statement re: colorbar…
4a2327d 
…s in image tutorial.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 1, 2019
Merged
@anntzer anntzer deleted the imagetut branch December 1, 2019 17:20
timhoffm added a commit that referenced this pull request Dec 1, 2019
@timhoffm
Merge pull request #15803 from meeseeksmachine/auto-backport-of-pr-15…
999a403 
…795-on-v3.2.x

Backport PR #15795 on branch v3.2.x (Remove incorrect statement re: colorbars in image tutorial.)
@QuLogic QuLogic modified the milestones: v3.2.1, v3.2.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic