Skip to content

Improve docs on figure size #15805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Dec 2, 2019

PR Summary

@tacaswell tacaswell added this to the v3.3.0 milestone Dec 2, 2019

Notes
-----
To transform from pixels to inches divide by `Figure.dpi`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should be pointing this out explicitly. I think that 90% of the time we don't want people to think in pixels. Also, when saving, Figure.dpi is just a default anyway. I'd prefer this discussion happen in savefig.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume pixels is more or less what people are actually thinking in most of the time, because that's their target unit if they draw to screen or png. At least, that's my experience. - Also it's the unit GUI frameworks, websites (often), image programs etc use. Maybe Graphics designers and TeX people don't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even the web is moving towards device independence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a note, and people are looking for this info:
https://stackoverflow.com/questions/29702424/how-to-get-matplotlib-figure-size

@jklymak jklymak merged commit 37074c5 into matplotlib:master Dec 3, 2019
@timhoffm timhoffm deleted the doc-figwidth branch December 3, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants