Skip to content

Allow failure on nightly builds. #15830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

Allow failure on nightly builds. #15830

merged 1 commit into from
Dec 4, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 4, 2019

PR Summary

Will selfmerge to unbreak the build.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Dec 4, 2019
@dstansby
Copy link
Member

dstansby commented Dec 4, 2019

Haha was just about to open this exact PR!

dstansby
dstansby requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't you need to get rid of the nightly build in the normal block above? (line 85 >)

@anntzer
Copy link
Contributor Author

anntzer commented Dec 4, 2019

No? We still want to run the test suite (it's nice to catch the changes on numpy nightly), just not prevent PRs from being merged over that.

dstansby
dstansby approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot how travis files work...

@dstansby dstansby merged commit 2555e38 into matplotlib:master Dec 4, 2019
@anntzer anntzer deleted the failnight branch December 4, 2019 14:48
@tacaswell tacaswell added this to the v3.3.0 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @tacaswell