Fix build with numpy master. #15833
Closed
Fix build with numpy master. #15833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, fix places where we build object arrays implicitly, as that's deprecated on numpy master. The change to colors.py may possibly(?) make conversion to rgba actually slightly *faster* as we avoid the conversion to array in some cases.
|
Made obsolete by the reversion of numpy's patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, fix places where we build object arrays implicitly, as
that's deprecated on numpy master.
The change to colors.py may possibly(?) make conversion to rgba actually
slightly faster as we avoid the conversion to array in some cases.
(Edit: indeed, it's 2x faster in the relevant case, lifted this to its own PR: #15834.)
PR Summary
PR Checklist