-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Example for sigmoid function with horizontal lines #15914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! While we value your contribution, there is concern that the gallery is getting unwieldy. Can you please explain what this example is demonstrating that is not currently being documented in the gallery? |
Thanks for this kind message. |
You could add this to the annotating plots example rather than making a new example. |
@jklymak : Good point. |
I think grouping similar functionality into fewer examples makes it easier to find things visually rather than having to search a huge page. |
IMHO having a dedicated example for axhline/axvline makes sense. (Annotations are quite something different.) For this purpose, I actually like the proposed example. It contains both cases. It‘s a realistic example but still simple enough. However, the title and description should focus on the purpose; something like „Infinite horizontal and vertical lines“ not „Sigmoid function“. The text should explain what the functions create (the infinite h/v Lines at given y/x coordinates) and what this is commonly used for (indicate special values). |
Fake8 issues:
The second one is straight forward to solve. To solve the first one, add
to the |
That was quite a journey. |
I took the liberty to push a commit renaming the file from Will squash-merge after CI pass. Thanks a lot, and congratulations on your first contribution to Matplotlib! Hope to see you back some time. |
…914-on-v3.2.x Backport PR #15914 on branch v3.2.x (Example for sigmoid function with horizontal lines)
An example for a sigmoid functions with axhline.
