Raise an ValueError when Axes.pie accepts negative values #15923 #15935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Dec 14, 2019
lib/matplotlib/axes/_axes.py
Outdated
| @@ -2921,6 +2921,10 @@ def pie(self, x, explode=None, labels=None, colors=None, | |||
| "and will be removed %(removal)s; pass a 1D array instead.") | |||
| x = np.atleast_1d(x.squeeze()) | |||
|
|
|||
| for part in x: | |||
There was a problem hiding this comment.
Thanks, np.any(x<0) is neater!
|
Thanks for the PR. This should probably get a test as well... |
|
@jklymak Sure, I will add the test. |
jklymak
approved these changes
Dec 14, 2019
anntzer
approved these changes
Dec 14, 2019
|
Thanks for you contribution, hoping to see you around again :) |
|
@anntzer Happy to help! Thanks for this great opportunity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Issue #15923
Axes.pie accepts negative values which outputs the wrong pie chart. This issue is caused by not checking the positive and negative of all input wedge sizes of "x" in Axes.pie.
Now it will raise a ValueError, which indicates wedge sizes should be non-negative when feeding negative values into Axes.pie. It is done by adding an if condition right before calculating the portion of all sizes in the "x" `array.
PR Checklist