Merge the two usetex demos. #15947
Merged
Merge the two usetex demos. #15947
+63
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Dec 16, 2019
There was a problem hiding this comment.
I agree that having these in separate examples does not make sense. I'm wondering, does the second one add more use cases or is is just more elaborate?
Anyway, the code is quite lengthy, so that it's rather hard also to follow the code also for the relatively simple first example. rendered docs
I'd put them into a separate sphinxgallery document section, so that code and rendered image are next to each other for both plots.
Description could be improved as well, but I would accept as is as an incremental improvement.
They're demonstrating the same idea.
28d8f2a to
fe6c45c
Compare
|
Sure, just made a separate section. |
timhoffm
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're demonstrating the same idea.
PR Summary
PR Checklist