-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: check subplot kwargs #15966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: check subplot kwargs #15966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually am against these kinds of checks, but here I'll approve because it's such a basic entry point and the error is so mystifying.
Should we error on |
75d5200
to
02490b7
Compare
Is there a reason why one would want to write |
It doesn't work right now because we check |
a5ea45f
to
0ef53cf
Compare
0ef53cf
to
67117cc
Compare
PR Summary
Closes #15964
A couple more guard-rails for using
plt.subplot
when you really meantplt.subplots
.Old:
Now:
Wasn't sure if passing
nrows
orncols
should just error out.PR Checklist