Process clip paths the same way as regular Paths. #15970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, run NaN removal, clipping to figure boundary, snapping to pixel centers, and path simplification on it. This means if you plot a Path, and then clip some other artist with it, you will get properly aligned results.
dopplershift
approved these changes
Dec 18, 2019
anntzer
approved these changes
Dec 18, 2019
|
mplcairo does the same (but that was really an accidental, though welcome, side effect of having a single python-path -> c++ path loader). |
|
@QuLogic milestone this to whatever sounds good to you and merge yourself? |
|
Well, my preference is as far back as possible for Cartopy's sake, of course, but it's difficult to assess the effect since so little of the library uses clip paths itself. |
|
I think this can quite reasonably be called a bug fix. And having it in 3.2 would make it easier to get something into the next CartoPy release... |
|
Getting 3.2 rc3 tagged, published and publicized is on my to-do for this weekend. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 20, 2019
timhoffm
added a commit
that referenced
this pull request
Dec 20, 2019
…970-on-v3.2.x Backport PR #15970 on branch v3.2.x (Process clip paths the same way as regular Paths.)
QuLogic
added a commit
to QuLogic/cartopy
that referenced
this pull request
Jan 7, 2020
This is the only test that is affected by matplotlib/matplotlib#15970. The new image is correct, but the difference is small enough to just change the tolerance.
QuLogic
added a commit
to QuLogic/cartopy
that referenced
this pull request
Jan 7, 2020
This is the only test that is affected by matplotlib/matplotlib#15970. The new image is correct, but the difference is small enough to just change the tolerance.
QuLogic
added a commit
to QuLogic/cartopy
that referenced
this pull request
Jan 7, 2020
This is the only test that is affected by matplotlib/matplotlib#15970. The new image is correct, but the difference is small enough to just change the tolerance.
kacmak7
pushed a commit
to kacmak7/cartopy
that referenced
this pull request
Feb 26, 2020
This is the only test that is affected by matplotlib/matplotlib#15970. The new image is correct, but the difference is small enough to just change the tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Specifically, run NaN removal, clipping to figure boundary, snapping to pixel centers, and path simplification on it.
This means if you plot a Path, and then clip some other artist with it, you will get properly aligned results.
I'm not entirely sure whether it makes sense to run NaN removal and figure clipping on the clip path, but I put them in for consistency with other paths. There don't seem to be any tests that are affected by these two. The change to
lib/matplotlib/tests/baseline_images/test_offsetbox/offsetbox_clipping.pngis because the clip path is snapped and better aligns with the other path. The change tolib/matplotlib/tests/baseline_images/test_axes/imshow_clip.pngis a minor effect of path simplification on the clip path.Fixes #15952. It also fixes the problem in Cartopy (see SciTools/cartopy#1422) for some cases, but not all. I'll need to investigate that a bit further.
PR Checklist