Skip to content

Cleanup span_where. #15976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2019
Merged

Cleanup span_where. #15976

merged 1 commit into from
Dec 29, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 19, 2019

  • Make it a classmethod so that if called through a subclass, that
    subclass is returned.
  • Reword a bit the docstring (I think it's the kind of cases where
    non-numpydoc is actually more readable...).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup span_where.
fb3ea5e 
- Make it a classmethod so that if called through a subclass, that
  subclass is returned.
- Reword a bit the docstring (I think it's the kind of cases where
  non-numpydoc is actually more readable...).
@dstansby dstansby added this to the v3.3.0 milestone Dec 29, 2019
@dstansby dstansby merged commit 163aac0 into matplotlib:master Dec 29, 2019
@anntzer anntzer deleted the span_where branch December 29, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby