Skip to content

Deprecate unused features of normalize_kwargs. #16039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

Deprecate unused features of normalize_kwargs. #16039

merged 1 commit into from
Jan 13, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 29, 2019

The required, forbidden and allowed kwargs of normalize_kwargs have
never been used and add a significant amount of complexity to the
implementation of normalize kwargs, so get rid of them.

Looks like @tacaswell originally introduced forbidden for #5056 but I think this can be better implemented as a separate "merge-disjoint-dicts" helper.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer changed the title Remove unused features of normalize_kwargs. Deprecate unused features of normalize_kwargs. Dec 29, 2019
timhoffm
timhoffm reviewed Dec 30, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8:

./lib/matplotlib/tests/test_cbook.py:4:1: F401 'warnings' imported but unused

@anntzer
Copy link
Contributor Author

anntzer commented Dec 30, 2019

thanks, fixed

@QuLogic QuLogic requested a review from tacaswell December 30, 2019 22:42
timhoffm
timhoffm approved these changes Jan 1, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the simplification makes sense.

@anntzer
Deprecate unused features of normalize_kwargs.
498f41d 
The required, forbidden and allowed kwargs of normalize_kwargs have
never been used and add a significant amount of complexity to the
implementation of normalize kwargs, so get rid of them.
@tacaswell tacaswell added this to the v3.3.0 milestone Jan 13, 2020
@tacaswell tacaswell merged commit 0013547 into matplotlib:master Jan 13, 2020
@anntzer anntzer deleted the normalize-kwargs branch January 13, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm