Skip to content

Code style cleanup #16044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2019
Merged

Code style cleanup #16044

merged 1 commit into from
Dec 31, 2019

Conversation

timhoffm
Copy link
Member

PR Summary

  • Remove redundant parentheses
  • Property setters should not return anything
  • use if myvar: instead of if myvar != []:

timhoffm
timhoffm commented Dec 30, 2019
View reviewed changes
lib/mpl_toolkits/mplot3d/axis3d.py

@property
def v_interval(self):
return self.get_view_interval()

@d_interval.setter
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually a bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to have a test for this...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually just deprecate them, as they are just mplot3d-specific synonyms for {get,set}_{view,data}_interval...

Copy link
Member Author

@timhoffm timhoffm Dec 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a separate PR #16053.

anntzer
anntzer reviewed Dec 30, 2019
View reviewed changes
anntzer
anntzer reviewed Dec 30, 2019
View reviewed changes
anntzer
anntzer reviewed Dec 30, 2019
View reviewed changes
@timhoffm timhoffm mentioned this pull request Dec 31, 2019
Merged
@timhoffm timhoffm added this to the v3.3.0 milestone Dec 31, 2019
@anntzer anntzer merged commit cab5dcc into matplotlib:master Dec 31, 2019
@timhoffm timhoffm deleted the codestyle-cleanup branch January 1, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift left review comments

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @dopplershift @anntzer @jklymak