Deprecate parameters to colorbar which have no effect. #16051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flake8: |
|
thanks, rebased. |
94acd23 to
799d7b0
Compare
timhoffm
reviewed
Dec 31, 2019
| @@ -1155,6 +1155,16 @@ def remove(self): | |||
| self.ax.remove() | |||
|
|
|||
|
|
|||
| def _merge_disjoint_kwargs(d, **kwargs): | |||
| for k, v in kwargs.items(): | |||
There was a problem hiding this comment.
Should get a docstring. In particular, it should mention that d is a dict and is updated with kwargs. Also, I'd rather use _add_disjoint_kwargs. "merge" sounds more like it would return a new dict with the merged content.
799d7b0 to
2919363
Compare
timhoffm
approved these changes
Jan 1, 2020
Per changelog entry. I went for a custom helper in colorbar.py rather than a more general one in cbook as this allowed for a nicer message, and making the general helper handle the deprecation would be a bit unwieldy.
2919363 to
9753708
Compare
|
rebased |
jklymak
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per changelog entry.
I went for a custom helper in colorbar.py rather than a more general one
in cbook as this allowed for a nicer message, and making the general
helper handle the deprecation would be a bit unwieldy.
Supersedes #5056.
PR Summary
PR Checklist