Skip to content

Delay resolution of animation extra_args. #16081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Delay resolution of animation extra_args. #16081

merged 1 commit into from
Jan 4, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 3, 2020

This avoids a lookup error for third-party animation subclasses for
which there is no corresponding rcParam.

Supersedes #5404.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jan 4, 2020
Merged
6 tasks
@anntzer
Delay resolution of animation extra_args.
9adc431 
This avoids a lookup error for third-party animation subclasses for
which there is no corresponding rcParam.
@anntzer anntzer force-pushed the animation-extra_args branch from 13c377c to 9adc431 Compare January 4, 2020 15:24
@dopplershift dopplershift merged commit f4c25b2 into matplotlib:master Jan 4, 2020
@anntzer anntzer deleted the animation-extra_args branch January 4, 2020 23:02
@anntzer anntzer mentioned this pull request Jan 5, 2020
Closed
@QuLogic QuLogic added this to the v3.3.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @timhoffm @QuLogic