Cleanup unused variables #16097
Merged
Cleanup unused variables #16097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f95b394 to
1bf3880
Compare
timhoffm
commented
Jan 4, 2020
| vspaces = [[] for i in range((rows + 1) * cols)] | ||
| hspaces = [[] for i in range(rows * (cols + 1))] | ||
| vspaces = [[] for _ in range((rows + 1) * cols)] | ||
| hspaces = [[] for _ in range(rows * (cols + 1))] |
There was a problem hiding this comment.
Initially, I tried to shorten these further to
vspaces = [[]] * ((rows + 1) * cols)
hspaces = [[]] * (rows * (cols + 1))
But for some reason, this caused test failures.
There was a problem hiding this comment.
Unfortunately, it is not the same thing:
>python -c "a = [[]] * 2; a[0].append(123); print(a)"
[[123], [123]]
P.S: I think those can be turned into numpy arrays of python lists.
There was a problem hiding this comment.
Thanks, of course it's not the same. 🙄
I leave numpy-fication for later. I suspect one could use numpy also further down to speed things up a little, but it needs a closer look.
This includes local variables and parameters of internal functions.
1bf3880 to
00bbd00
Compare
Kojoley
approved these changes
Jan 5, 2020
QuLogic
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Cleanup: