-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate parameter props of Shadow #16098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What would be the usecase for those kwargs? Since they will be overridden afterwards anyways (i.e. |
Fair point. Actually, the properties for the shadow can be passed via prop, see e.g. https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/demo_text_path.html; and they are not overridden. I've now deprecated This would now fit into #16096 (hence the particular deprecation comment). But I'll leave this standalone and merge the conflict in case anybody has different opinions on |
I think deprecating props and making kwargs work looks better (it's more consistent with basically all mpl APIs...) but won't insist on it either. |
Actually, there's a suprising number of |
Gone for deprecating |
@anntzer Do you want to re-review because the content of the PR changed completely after your approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1afa73c
to
02a9d2e
Compare
Starting with matplotlib#16098, extra keyword arguments are now processed, but that means that default colours and alpha are not set. Instead, those properties should only be overridden if specified.
PR Summary
I was about to deprecate
**kwargs
with the previous PR on unused parameters. But according to the docs, kwargs should be supported.Note: This has been in there since 2004, so I'm refraining from backporting due to lack of significance.