Rework example "Scatter Star Poly" to "Marker examples" #16102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelleV
approved these changes
Jan 8, 2020
| Scatter Star Poly | ||
| ================= | ||
| =============== | ||
| Marker examples |
There was a problem hiding this comment.
I'm not a big fan of this title: it doesn't summarizes what the example showcases in particular compared to all of the other examples on markers.
There was a problem hiding this comment.
I agree that it's not very instructive. But I didn't find a better name. OTOH, the example itself doesn't add much compared to the maker reference and module docs. I was about to delete it but decided to keep it as a usage example.
If you can think of a better name, proposals are always welcome.
There was a problem hiding this comment.
I'd be in favor of removing it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
"Create multiple scatter plots with different star symbols." seems not super-useful as an example. Additionally, it did not really do that. This is essentially a completely new example: