Skip to content

Move locking of fontlist.json *into* json_dump. #16111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Move locking of fontlist.json *into* json_dump. #16111

merged 1 commit into from
Mar 31, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 5, 2020

This makes it easier for end users to call json_dump (which is public
API) safely, given that _lock_path is not public API.

Side point of the discussion at #15943.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jan 5, 2020
Merged
6 tasks
timhoffm
timhoffm reviewed Jan 5, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to note this also in the docstring of json_dump.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 5, 2020

done

@QuLogic QuLogic mentioned this pull request Mar 24, 2020
Merged
6 tasks
@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2020

rebased

@tacaswell
Copy link
Member

Needs a rebase again, @anntzer can merge on CI green.

@anntzer
Move locking of fontlist.json *into* json_dump.
69ccb73 
This makes it easier for end users to call json_dump (which is public
API) safely, given that _lock_path is not public API.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 31, 2020

rebased

@anntzer anntzer added this to the v3.3.0 milestone Mar 31, 2020
@anntzer anntzer merged commit d397831 into matplotlib:master Mar 31, 2020
@anntzer anntzer deleted the json_dump_lock branch March 31, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @QuLogic @timhoffm