Skip to content

CI: Fail when failed to install dependencies #16112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kojoley
Copy link
Member

@Kojoley Kojoley commented Jan 5, 2020

font-wenquanyi-zen-hei was removed from Homebrew Homebrew/homebrew-cask-fonts#1924

I will try to change the font for Noto Sans CJK in subsequent PR.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

`font-wenquanyi-zen-hei` was removed from Homebrew
Homebrew/homebrew-cask-fonts#1924
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once ci passes

@NelleV
Copy link
Member

NelleV commented Jan 6, 2020

Thanks @Kojoley !

@NelleV NelleV merged commit 7331781 into matplotlib:master Jan 6, 2020
@Kojoley Kojoley deleted the ci-travis-fail-when-dep-install-fails branch January 6, 2020 13:07
@QuLogic QuLogic added this to the v3.3.0 milestone Jan 7, 2020
@Kojoley Kojoley modified the milestones: v3.3.0, v3.1.3 Jan 7, 2020
@Kojoley
Copy link
Member Author

Kojoley commented Jan 7, 2020

@meeseeksdev backport to v3.1.x
@meeseeksdev backport to v3.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 7, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7331781663a5ea26dab5bba5bc6be10ef97a41ad
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16112: CI: Fail when failed to install dependencies'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16112-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16112 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
Kojoley pushed a commit to Kojoley/matplotlib that referenced this pull request Jan 7, 2020
…dep-install-fails

CI: Fail when failed to install dependencies
Kojoley pushed a commit to Kojoley/matplotlib that referenced this pull request Jan 7, 2020
…dep-install-fails

CI: Fail when failed to install dependencies
Kojoley added a commit that referenced this pull request Jan 7, 2020
Backport PR #16112 on branch v3.2.x (CI: Fail when failed to install dependencies)

Co-authored-by: Nelle Varoquaux <nelle.varoquaux@gmail.com>
Kojoley added a commit that referenced this pull request Jan 7, 2020
Backport PR #16112 on branch v3.1.x (CI: Fail when failed to install dependencies)

Co-authored-by: Nelle Varoquaux <nelle.varoquaux@gmail.com>
@QuLogic QuLogic modified the milestones: v3.1.3, v3.2.0 Jan 8, 2020
Kojoley pushed a commit to Kojoley/matplotlib that referenced this pull request Jan 9, 2020
…dep-install-fails

CI: Fail when failed to install dependencies
tacaswell added a commit that referenced this pull request Jan 20, 2020
…dependencies) (#16137)

* Merge pull request #16112 from Kojoley/ci-travis-fail-when-dep-install-fails

CI: Fail when failed to install dependencies

* CI: backport osx on travis changes en-mass

This will move testing on travis to python3 (from python2), however I
am not sure it is worth the effort of moving brew on travis back to
python2 so that we can in very short order delete this branch and
close out the 2.2.x series (now that python2 is EOL).

* CI: accept that brew will be verbose

* CI: bump sphinx version to pick up support for newer docutils

* CI: remove mac builds on travis

The brew configuration has bit-rotted

* CI: remove the nightly build from travis

* CI: add py38 to build matrix

* Revert "CI: remove mac builds on travis"

This reverts commit 4da7fa1.

* CI: try removing the osx_image specification

Co-authored-by: Nelle Varoquaux <nelle.varoquaux@gmail.com>
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants