Skip to content

Minor fontproperty fixes. #16120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Minor fontproperty fixes. #16120

merged 1 commit into from
Jan 7, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 6, 2020

  • In Text.__init__, use the fontproperties setter, which makes a copy
    of the FP instance, and allows deduping the str-support logic.
  • In FontProperties, inline the call to parse_fontconfig_pattern -- the
    extra indirection via self._parse_fontconfig_pattern doesn't buy
    anything.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Minor fontproperty fixes.
d6d3ce5 
- In `Text.__init__`, use the fontproperties setter, which makes a copy
  of the FP instance, and allows deduping the str-support logic.
- In FontProperties, inline the call to parse_fontconfig_pattern -- the
  extra indirection via self._parse_fontconfig_pattern doesn't buy
  anything.
Kojoley
Kojoley approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@Kojoley Kojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FontProperties().copy() is cheap (15us)

@Kojoley Kojoley merged commit 03d98f1 into matplotlib:master Jan 7, 2020
@Kojoley Kojoley added this to the v3.2.1 milestone Jan 7, 2020
@anntzer anntzer deleted the fp branch January 7, 2020 15:29
@QuLogic QuLogic modified the milestones: v3.2.1, v3.3.0 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@Kojoley Kojoley Kojoley approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @Kojoley