Validate Line2D pickradius when setting it, not when reading it. #16134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Jan 7, 2020
| @@ -507,7 +504,11 @@ def set_pickradius(self, d): | |||
| d : float | |||
| Pick radius, in points. | |||
| """ | |||
| self.pickradius = d | |||
| if not isinstance(d, Number): | |||
| raise ValueError("pick radius should be a distance") | |||
There was a problem hiding this comment.
Great to move this. But should it also be a positive number?
1e7da60 to
969a485
Compare
jklymak
approved these changes
Jan 7, 2020
timhoffm
approved these changes
Jan 7, 2020
| @@ -507,7 +504,11 @@ def set_pickradius(self, d): | |||
| d : float | |||
| Pick radius, in points. | |||
| """ | |||
| self.pickradius = d | |||
| if not isinstance(d, Number) or d < 0: | |||
There was a problem hiding this comment.
Does a pick radius of 0 make sense? It would trigger only if you hit that pixel. Likely set_pickradius(0) might be misunderstood as deactivating picking. Anyway, let's not be overly restrictive. -> ok.
There was a problem hiding this comment.
I don't think zero makes more or less sense than 0.001, for example (especially given that GUI toolkits will typically only report events with a precision of 1px anyways), so I wouldn't overly worry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist