Skip to content

Cleanup hist() docstring. #16160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Cleanup hist() docstring. #16160

merged 1 commit into from
Jan 8, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 8, 2020

Just mechanical stuff.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Just mechanical stuff.
@Kojoley Kojoley added this to the v3.1.3 milestone Jan 8, 2020
@jklymak jklymak merged commit 65349e1 into matplotlib:master Jan 8, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 8, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 65349e10c507a974110ea63a54d3e3205d05b40c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16160: Cleanup hist() docstring.'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16160-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16160 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 8, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 65349e10c507a974110ea63a54d3e3205d05b40c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16160: Cleanup hist() docstring.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16160-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16160 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the histdoc branch January 8, 2020 14:17
@timhoffm
Copy link
Member

timhoffm commented Jan 8, 2020

There were too many documentation changes lately. Since this is not essential, I wouldn't go through the troubles of backporting.

@jklymak
Copy link
Member

jklymak commented Jan 8, 2020

The change @anntzer based this on was not back ported, so this didn't back port properly. I don't think its super necessary to back port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants