And more missing references. #16172
Merged
And more missing references. #16172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Jan 12, 2020
|
rebased |
The `FormatStrFormatterNewStyle` name added in 04c734c was just wrong (it refers to an old name that went away during the PR review). `{get,format}_pixel_data` were renamed to `{get,format}_cursor_data` during review in cd0e52b. The docstring of violin_stats was edited to remove awkward wording wrt. required keys in dicts; these keys are properly listed in the docstring of bxp() anyways. The comment re: multiline prop_cycles is just plain wrong -- matplotlibrc files never supported any kind of line continuation.
NelleV
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FormatStrFormatterNewStylename added in 04c734c was just wrong(it refers to an old name that went away during the PR review).
The docstring of violin_stats was edited to remove awkward wording wrt.
required keys in dicts; these keys are properly listed in the docstring
of bxp() anyways.
The comment re: multiline prop_cycles is just plain wrong --
matplotlibrc files never supported any kind of line continuation.
PR Summary
PR Checklist