Skip to content

UnCamelCase examples. #16201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

UnCamelCase examples. #16201

merged 1 commit into from
Jan 13, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 13, 2020

The changes in basic_units are possible because the unit framework now
correctly handles unit subclasses, so we don't need to register
dynamically created subclasses (since #13536).

Followup to https://github.com/matplotlib/matplotlib/pull/16199/files; I think the only remaining cases are callback names in wx examples.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
UnCamelCase examples.
ebde562 
The changes in basic_units are possible because the unit framework now
correctly handles unit subclasses, so we don't need to register
dynamically created subclasses.
timhoffm
timhoffm approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also unsure about the wx callback names. Does anybody know if there are common conventions for these?

@timhoffm timhoffm added this to the v3.3.0 milestone Jan 13, 2020
@timhoffm timhoffm merged commit ec83125 into matplotlib:master Jan 13, 2020
@anntzer anntzer deleted the camelicide branch January 13, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm