Skip to content

Deprecate the empty matplotlib.compat. #16205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Deprecate the empty matplotlib.compat. #16205

merged 1 commit into from
Jan 15, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 13, 2020

If we ever need something like it again we'll likely make the compat
shims private anyways...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 13, 2020
@anntzer
Deprecate the empty matplotlib.compat.
a45ae10 
If we ever need something like it again we'll likely make the compat
shims private anyways...
NelleV
NelleV approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anntzer

@NelleV NelleV merged commit e0063d3 into matplotlib:master Jan 15, 2020
@anntzer anntzer deleted the uncompat branch January 15, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @NelleV @timhoffm