Skip to content

Fix deprecation from #13544 #16212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fix deprecation from #13544 #16212

merged 1 commit into from
Jan 14, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

From #13544 (comment)

@timhoffm timhoffm added status: confirmed bug Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jan 13, 2020
@timhoffm timhoffm added this to the v3.2.0 milestone Jan 13, 2020
anntzer
anntzer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.

@NelleV NelleV merged commit a8ed66d into matplotlib:master Jan 14, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 14, 2020
@NelleV @meeseeksmachine
Backport PR matplotlib#16212: Fix deprecation from matplotlib#13544
f8c9cfc
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 14, 2020
Merged
@NelleV
Copy link
Member

NelleV commented Jan 14, 2020

Thanks @timhoffm
In general, when bugs are detected, a unit test should be added. It is surprisingly not in our reviewer/contributing guidelines, but we have in the past reintroduced bugs by not consistently writing unit tests.

@timhoffm timhoffm deleted the fix-deprecation branch January 14, 2020 19:33
@timhoffm
Copy link
Member Author

@NelleV In general I agree, but we almost certainly won't touch this deprecated code anymore before removing. So I don't think it's worth the effort adding a test now.

timhoffm added a commit that referenced this pull request Jan 14, 2020
@timhoffm
Merge pull request #16222 from meeseeksmachine/auto-backport-of-pr-16…
dc9d5ae 
…212-on-v3.2.x

Backport PR #16212 on branch v3.2.x (Fix deprecation from #13544)
@Fealthas Fealthas mentioned this pull request Jan 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: confirmed bug
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @NelleV @anntzer