Added DNA Features Viewer description + screenshot in docs/thirdparty/ #16223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jan 14, 2020
There was a problem hiding this comment.
Thanks for the contribution. This looks really nice!
-
Please crop the image to max. 900px width. Larger images extend the layout column (https://29192-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/thirdpartypackages/index.html#dna-features-viewer).
-
Please run the png through an image compressor such as https://tinypng.com/. There are a lot of images on the third-party page. We try to keep their sizes minimal to reduce loading time.
|
Done! |
|
(As a tangent, writing a quick and dirty a plasmid viewer was at the origin of one of my first PRs to matplotlib: #1635 :-)) |
|
Nice! My library implements an ArrowWedge on top of your Wedge. |
timhoffm
approved these changes
Jan 14, 2020
|
Thanks a lot! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 14, 2020
… screenshot in docs/thirdparty/
tacaswell
added a commit
that referenced
this pull request
Jan 15, 2020
…223-on-v3.2.x Backport PR #16223 on branch v3.2.x (Added DNA Features Viewer description + screenshot in docs/thirdparty/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added a section to
docs/thirdpartypackages/index.rstto present DNA Features Viewer (DNA sequence map plots with Matplotlib), as per this Twitter discussion.Screenshot:
PR Checklist