-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use the right function to disable the offset #16239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Interestingly,
does not result in any offset with current matplotlib. Hence this needs to change anyways for the whole paragraph to make sense. So suppose it is
instead. Then, using Concerning the "multiplicative offset", another example can be added. E.g. if
then adding The difference between the two is not well documented anywhere. So it would in addition make sense to add a respective paragraph in the ticks-and-ticklabels section of the text tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm blocking this. set_scientific
is not correct here. This is a misconception originating in poor docs. See linked PRs.
Thanks a lot. If you fix the matplotlib behavior in order to provide 2 independent concepts for offset and scientific notation, it is far better. But if you only update the docstring, you only provide documentation which do not match the actual matplotlib behavior. So, do you plan to fix the behavior? Is there a related issue i can follow? Thanks a lot. |
Definitely not. Else, disabling scientific notation should not be needed to disable the offset. This said, i did not checked it again since January. |
Oh, yes, in fact the issue was on my PR description: #16232 |
I've commented in #16232 on that. |
I see, there is an offset and a factor. Thanks a lot for the clarification. |
PR Summary
This PR update the example from the documentation to use the proper function to avoid using scientific offset in the plot.
Relative to this discussion #16232
Closes #16232
Fill free to close this PR and the related issue if it do not fit.
PR Checklist