Skip to content

Cleanup custom_scale example. #16240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Cleanup custom_scale example. #16240

merged 1 commit into from
Jan 16, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 16, 2020

  • Various docstring cleanups.
  • The axisbelow hack is not necessary anymore (custom_scale_example.py fails with axisbelow True #6312 (comment)).
  • Use a normal FuncFormatter instead of a custom Formatter subclass.
    (We can reuse the same formatter for major and minor ticks.)
  • No need to make political statements about the Mercator projection.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup custom_scale example.
463614d 
- Various docstring cleanups.
- The axisbelow hack is not necessary anymore.
- Use a normal FuncFormatter instead of a custom Formatter subclass.
  (We can reuse the same formatter for major and minor ticks.)
- No need to make political statements about the Mercator projection.
@tacaswell tacaswell added this to the v3.3.0 milestone Jan 16, 2020
@tacaswell tacaswell merged commit 569e12e into matplotlib:master Jan 16, 2020
@anntzer anntzer deleted the scalex branch January 16, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @tacaswell