Fix errorbar zorder v1.2 #1628
Merged
Fix errorbar zorder v1.2 #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 3.1 build failed with errors that look like Travis didn't actually use 3.1 to run the tests. |
|
@tacaswell Thanks for the patch. I'll leave this up for a day or so to allow the opinions of others to roll in before merging. |
|
A related issue: #409 |
|
@WeatherGod Does this patch fix that issue for you? |
|
I have yet to check, I was merely noting it for posterity. I have a huge backlog of emails to work through today... |
Do not need to explicitly call set_zorder because it gets done in the call to coll.update.
|
+1 |
| ax.axhline(1,color='red',lw=10,zorder=1) | ||
| ax.axhline(5,color='green',lw=10,zorder=10) | ||
| ax.axvline(7,color='m',lw=10,zorder=7) | ||
| ax.axvline(2,color='k',lw=10,zorder=3) |
There was a problem hiding this comment.
PEP8: A space is needed after each comma in the above calls to ax[vh]line.
|
Once those nitpicks are addressed I'll merge this. Thanks @tacaswell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #1622 + unit test.